-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-10582: [Rust] [DataFusion] Implement "repartition" operator #8982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
84b0824
rough out new repartition physical operator
andygrove 3c35af9
combine partitioning enums
andygrove 7472e25
roughing out more of the impl
andygrove 634c626
save progresS
andygrove ff1dbbc
save progress
andygrove f5dff60
use async-channel
andygrove d546890
operator maybe code complete
andygrove 72869d4
improve error handling
andygrove 9c7716b
plumb through to LogicalPlan and DataFrame
andygrove 1441d85
Update TPC-H file conversion to support optional repartitioning
andygrove a9f4b42
repartition operator works functionally
andygrove d845f92
docs
andygrove 16b69f7
add unit test
andygrove 655426b
fix test
andygrove a7483df
more tests
andygrove 67ee55e
tests pass
andygrove 23c0b6c
Remove TODO comment
andygrove 6c765d7
rename num_output_partition to num_output_partitions and improve docu…
andygrove dc992df
combine senders and receivers in single vec to reduce mutex use
andygrove 66aa0fc
Update rust/datafusion/src/physical_plan/repartition.rs
andygrove aabdf94
address feedback
andygrove File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this introduces a new naming,
partitioning_scheme.We have:
partitionpartitioningpartitioning_schemerepartitionpartI do not know the common notation, but we could try to reduce the number of different names we use.
In my (little) understanding:
partitionpartsrepartitionit according to a newpartition.In this understanding, I would replace
partitioningandpartitioning_schemebypartition.Even if this understanding is not correct, maybe we could reduce the number of different names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree keeping the number of different names low is important
I suggest using
partitionto refer to an actual portion of the data (in a bunch ofRecordBatches)partitioningto refer to the "schema" of how the data is divided intopartitions (the use of thePartitioningscheme now)Thus we would
repartitionthe data into a newpartitioning