ARROW-1204: [C++] Remove WholeProgramOptimization(/GL) compilation fl… #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ag for lz4 and zstd libs
maxhora
commented
Jul 26, 2017
| if (MSVC) | ||
| set(ZSTD_STATIC_LIB "${ZSTD_BUILD_DIR}/build/VS2010/bin/x64_${CMAKE_BUILD_TYPE}/libzstd_static.lib") | ||
| set(ZSTD_BUILD_COMMAND BUILD_COMMAND msbuild ${ZSTD_BUILD_DIR}/build/VS2010/zstd.sln /t:Build /v:minimal /p:Configuration=${CMAKE_BUILD_TYPE} /p:Platform=x64 /p:PlatformToolset=v140 /p:OutDir=${ZSTD_BUILD_DIR}/build/VS2010/bin/x64_${CMAKE_BUILD_TYPE}/ /p:SolutionDir=${ZSTD_BUILD_DIR}/build/VS2010/ ) | ||
| set(ZSTD_PATCH_COMMAND PATCH_COMMAND git --git-dir=. apply --verbose ${CMAKE_SOURCE_DIR}/build-support/zstd_msbuild_wholeprogramoptimization_param.patch) |
Contributor
Author
There was a problem hiding this comment.
@wesm , just setting of --git-dir= to specify root directory of repository is enough to make git apply workable to apply patches. It works at list for Windows :)
xhochy
reviewed
Jul 26, 2017
Member
xhochy
left a comment
xhochy
left a comment
There was a problem hiding this comment.
I'm a bit confused that we patch here using git although we have a non-git source tarball. Why cannot we use the patch command. Is there no equivalent on Windows/AppVeyor?
Member
|
Right, there's no patch equivalent on Windows AFAIK |
Member
|
We should probably report these issues upstream? |
Contributor
Author
Member
|
@Maxris good to know. Then we can keep it this way as long as users don't complain for the git dependency ;) |
wesm
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ag for lz4 and zstd libs