-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-10907: [Rust] Fix Cast UTF8 to Date64 #8918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8918 +/- ##
===========================================
- Coverage 75.35% 51.90% -23.46%
===========================================
Files 177 173 -4
Lines 40821 31082 -9739
===========================================
- Hits 30762 16132 -14630
- Misses 10059 14950 +4891
Continue to review full report at Codecov.
|
nevi-me
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See latest commits in #8913. There is a default parser for the same format that also avoids parsing the format for each value (faster), and also supports the decimal fraction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Dandandan will update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have updated with your suggested changes. thank you very much - this helps me learn.
f02a51d to
1863c08
Compare
|
Thanks @Dandandan and @seddonm1 👍 |
This PR fixes the behavior of a UTF8 -> Date64 conversion process to use
%Y-%m-%dT%H:%M:%Srather than%Y-%m-%dwith00:00:00time component.It aligns with #8913.