Skip to content

Conversation

@seddonm1
Copy link
Contributor

This PR fixes the behavior of a UTF8 -> Date64 conversion process to use %Y-%m-%dT%H:%M:%S rather than %Y-%m-%d with 00:00:00 time component.

It aligns with #8913.

@seddonm1 seddonm1 changed the title ARROW-10907: [Rust] Correct date64 behavior ARROW-10907: [Rust] Fix Cast UTF8 to Date64 Dec 14, 2020
@github-actions
Copy link

@codecov-io
Copy link

codecov-io commented Dec 14, 2020

Codecov Report

Merging #8918 (1863c08) into master (408e5be) will decrease coverage by 23.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #8918       +/-   ##
===========================================
- Coverage   75.35%   51.90%   -23.46%     
===========================================
  Files         177      173        -4     
  Lines       40821    31082     -9739     
===========================================
- Hits        30762    16132    -14630     
- Misses      10059    14950     +4891     
Impacted Files Coverage Δ
rust/datafusion/src/physical_plan/expressions.rs 0.00% <ø> (ø)
rust/arrow/src/compute/kernels/cast.rs 96.21% <100.00%> (-0.13%) ⬇️
rust/parquet/src/column/page.rs 0.00% <0.00%> (-98.69%) ⬇️
rust/parquet/src/record/api.rs 0.00% <0.00%> (-98.15%) ⬇️
rust/parquet/src/arrow/arrow_writer.rs 0.00% <0.00%> (-97.34%) ⬇️
rust/parquet/src/basic.rs 0.00% <0.00%> (-97.27%) ⬇️
rust/parquet/src/file/properties.rs 0.00% <0.00%> (-95.73%) ⬇️
rust/parquet/src/file/serialized_reader.rs 0.00% <0.00%> (-95.62%) ⬇️
rust/parquet/src/file/writer.rs 0.00% <0.00%> (-95.11%) ⬇️
rust/parquet/src/arrow/record_reader.rs 0.00% <0.00%> (-94.54%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb1ed5...1863c08. Read the comment docs.

Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Dandandan Dandandan Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See latest commits in #8913. There is a default parser for the same format that also avoids parsing the format for each value (faster), and also supports the decimal fraction

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dandandan will update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have updated with your suggested changes. thank you very much - this helps me learn.

@alamb alamb closed this in 970a9e7 Dec 15, 2020
@alamb
Copy link
Contributor

alamb commented Dec 15, 2020

Thanks @Dandandan and @seddonm1 👍

@seddonm1 seddonm1 deleted the fix-date64-cast branch December 16, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants