Skip to content

Conversation

@wesm
Copy link
Member

@wesm wesm commented Jul 25, 2017

Change-Id: I52635d8682c2651068bc4bd003c078c4cc711beb
@wesm wesm changed the title ARROW-1258: [C++} Suppress Clang dlmalloc compiler warnings ARROW-1258: [C++] Suppress Clang dlmalloc compiler warnings Jul 25, 2017
@pcmoritz
Copy link
Contributor

Thank a lot for this! The changes look good to me. On both my local mac and linux there are no warnings any more, on travis linux there is still a few of these:

In file included from /home/travis/build/apache/arrow/cpp/src/plasma/malloc.cc:45:0:
/home/travis/build/apache/arrow/cpp/src/plasma/thirdparty/dlmalloc.c: In function ‘void* prepend_alloc(mstate, char*, char*, size_t)’:
/home/travis/build/apache/arrow/cpp/src/plasma/thirdparty/dlmalloc.c:3982:892: warning: conversion to ‘unsigned int’ from ‘size_t {aka long unsigned int}’ may alter its value [-Wconversion]
     insert_chunk(m, q, qsize);
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            ^

https://travis-ci.org/apache/arrow/jobs/257422813

Change-Id: Id787697b6daba584b1e66bacb4b91a595b624d9b
@asfgit asfgit closed this in e9e17b5 Jul 26, 2017
@wesm wesm deleted the ARROW-1258 branch July 26, 2017 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants