ARROW-10826: [Rust] Add support for FixedSizeBinaryArray to MutableArrayData #8852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Dec 6, 2020
Contributor
There was a problem hiding this comment.
I am having trouble figuring out why this is the expected output. I expected something like
let expected = FixedSizeBinaryArray::from(vec![vec![0, 1], vec![0, 0]]);
As I read
mutable.extend(0, 1, 2); // --> pick element 1 (aka vec[0, 1])
mutable.extend(0, 0, 1); // --> pick element 0 (aka vec[0, 0])
Member
Author
There was a problem hiding this comment.
I am sorry, I should have documented the test better. I added a comment to it. Does it became understandable with the comment? The idea is to check that this works with arrays with offsets.
Contributor
There was a problem hiding this comment.
oh, man, I missed the call to let array = array.slice(1, 2); 👍 thanks @jorgecarleitao
alamb
approved these changes
Dec 6, 2020
Contributor
There was a problem hiding this comment.
oh, man, I missed the call to let array = array.slice(1, 2); 👍 thanks @jorgecarleitao
github-actions
bot
added
the
needs-rebase
github-actions
bot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.