ARROW-1253: [C++/Python] Speed up C++ / Python builds by using conda-forge toolchain for thirdparty libraries #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@xhochy I added ninja to the toolchain for potentially faster builds, we will see how it impacts runtimes |
…rebuilding EPs. Use ninja for builds when using toolchain
Change-Id: Ie86954b96207dbbd56ac4111d95400364a199639
Change-Id: Icb2e476e3a9d0f38a6a1b56523c53d6c843bb26d
pcmoritz
reviewed
Jul 25, 2017
Contributor
pcmoritz
left a comment
pcmoritz
left a comment
There was a problem hiding this comment.
+1 looks great to me! Thanks for doing this!
cpp/src/plasma/.gitignore
Outdated
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| *_generated.h No newline at end of file |
ci/travis_script_python.sh
Outdated
| @@ -1,3 +1,4 @@ | |||
|
|
|||
Change-Id: I65a227e91ccbe4bf36c2d4da165433f941eafc08
Member
Author
|
Appveyor looks happy so I'm going to merge this https://ci.appveyor.com/project/wesm/arrow/build/1.0.737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pcmoritz I removed the travis_script_plasma.sh and combined the common bits with travis_script_python.sh; it seemed like there was some redundant work and would be easier to test everything in a single build. Let me know if I messed something up