Skip to content

Conversation

@siddharthteotia
Copy link
Contributor

This will allow us to do some cleanup in Dremio where we have written wrapper routines using Reflection to access the fillEmpties method of mutator.

Unit tests have been added.

@siddharthteotia
Copy link
Contributor Author

siddharthteotia commented Jul 24, 2017

@jacques-n

@siddharthteotia siddharthteotia changed the title ARROW-1249: expose fillEmpties from Nullable variable length vectors ARROW-1249: [JAVA] expose fillEmpties from Nullable variable length vectors Jul 24, 2017
@siddharthteotia
Copy link
Contributor Author

Retriggered the build.

@wesm
Copy link
Member

wesm commented Jul 24, 2017

The build failure was unrelated to your changes. Pending ARROW-1253 I think it's OK to merge if that particular build entry fails

@siddharthteotia
Copy link
Contributor Author

Thanks @wesm

@siddharthteotia
Copy link
Contributor Author

The build job timed out again. Since the time limit issue with Travis CI build is a known problem, this PR can probably be merged.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I will put up a patch about build performance on that one later tonight if possible, worst case tomorrow

@asfgit asfgit closed this in ecdc86b Jul 25, 2017
@siddharthteotia siddharthteotia deleted the ARROW-1249 branch July 25, 2017 03:15
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
…ectors

This will allow us to do some cleanup in Dremio where we have written wrapper routines using Reflection to access the fillEmpties method of mutator.

Unit tests have been added.

Author: siddharth <[email protected]>

Closes apache#880 from siddharthteotia/ARROW-1249 and squashes the following commits:

e0532c5 [siddharth] Merge branch 'ARROW-1249' of https://github.com/siddharthteotia/arrow into ARROW-1249
dc05206 [siddharth] ARROW-1249: Expose fillEmpties() from Nullable Variable Length Vectors
f24d8f1 [siddharth] ARROW-1249: expose fillEmpties from Nullable variable length vectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants