ARROW-10513: [Rust]: ARMv7 compilation #8609
Conversation
nevi-me
left a comment
nevi-me
left a comment
There was a problem hiding this comment.
Looks like the main change is accounting for the pointer/usize size in tests, so I'm happy with this.
I didn't look at the bit_vec changes, as those are from the other PR. I'll come back to this after we address that PR
rust/arrow/src/array/union.rs
Outdated
There was a problem hiding this comment.
I struggled to follow the arithmetic here, but perhaps I need to look at the spec again
There was a problem hiding this comment.
Please do. Calculated nestedness and pointer table from my mind. Just tried to write a little bit more clearly which part of the pointers accounts for which part of the arrays with this pr.
|
@vertexclique would we be able to use https://crates.io/crates/cross for the armv7 CI? |
|
Yup, we can do that. I will remove all bit slice iterator implementation from this PR and make it only to work on arm LE. Then we can use it. |
vertexclique
force-pushed
the
ARROW-10513-enable-arrow-armv7
branch
from
3e9cc40 to
e27e127
Compare
|
@nevi-me enabled ci, let's see how it will go. |
github-actions
bot
removed
the
needs-rebase
github-actions
bot
added
the
needs-rebase
|
@vertexclique -- Given the imminent Arrow 3.0 release, I am trying to clean up older Rust PRs and see if the authors have plans to move them forward. Do you plan on working on this PR in the near future? If not, should we close this PR until there is time to make progress? Thanks again for your contributions so far. |
|
@alamb Thanks for reaching out! I don't have time to work on these PRs. Closing. |
4 participants
todos:
run on armv7:
run on armv6:
others: