ARROW-10476: [Rust] Allow string arrays to be built from Option<&str> or Option<String> #8575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
changed the title
vertexclique
approved these changes
Nov 4, 2020
Contributor
vertexclique
left a comment
vertexclique
left a comment
There was a problem hiding this comment.
Nice! It will help to the parquet indirectly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our code-base supports creating a
StringArrayfrom an iterator ofString.However, from arrow's perspective, we should not care if it is a
Stringor a&str, as long as it can be represented by anAsRef<str>. A user sometimes is able to create an iterator of&strinstead ofString, and should not have to convert one to the other before passing it to Arrow.This PR makes this change.