Skip to content

ARROW-10433 [Python] Swopped the conditions for checking for fsspec filesystems #8557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mariusvniekerk wants to merge 1 commit into from
Closed

ARROW-10433 [Python] Swopped the conditions for checking for fsspec filesystems #8557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions python/pyarrow/filesystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,10 +443,6 @@ def _ensure_filesystem(fs):
# If the arrow filesystem was subclassed, assume it supports the full
# interface and return it
if not issubclass(fs_type, FileSystem):
for mro in inspect.getmro(fs_type):
if mro.__name__ == 'S3FileSystem':
return S3FSWrapper(fs)

if "fsspec" in sys.modules:
fsspec = sys.modules["fsspec"]
if isinstance(fs, fsspec.AbstractFileSystem):
Expand All @@ -455,6 +451,10 @@ def _ensure_filesystem(fs):
# filesystems (which should be compatible with our legacy fs)
return fs

for mro in inspect.getmro(fs_type):
if mro.__name__ == 'S3FileSystem':
return S3FSWrapper(fs)

raise OSError('Unrecognized filesystem: {}'.format(fs_type))
else:
return fs
Expand Down