ARROW-10462: [Python] Fix usage of fsspec in ParquetDataset causing path issue on Windows #8539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
changed the title
jorisvandenbossche
force-pushed
the
ci-windows-fsspec
branch
from
8040408 to
647c855
Compare
| # In case its a simple LocalFileSystem (e.g. dask) use native arrow | ||
| # FS | ||
| elif mro.__name__ == 'LocalFileSystem': | ||
| return LocalFileSystem._get_instance() |
Member
Author
There was a problem hiding this comment.
The reason this now gives troubles (while this code was already there for more than 2 years), is because with pyarrow >= 2.0, fsspec will no longer inherit from pyarrow.filesystem.FileSystem, and so this path was only taken if the passed filesystem was not a pyarrow subclass (so before, in pyarrow.fs, we simply didn't take this code path for fsspec filesystems)
Member
Author
There was a problem hiding this comment.
I think it is fine to simply remove this code, as in practice this was also never run anymore with previous pyarrow releases. I suppose this was only ever reached with old fsspec versions that did not yet subclass pyarrow.
jorisvandenbossche
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.