ARROW-5394: [C++][Benchmark] IsIn and IndexIn benchmark for integer and string types #8529
Conversation
|
CI errors seem unrelated |
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Thank you for doing this. Here are some comments.
Also, can you rebase on git master?
There was a problem hiding this comment.
It doesn't seem logical to add this second term. The "items" processed are the input array items.
There was a problem hiding this comment.
Call this "SmallSet" instead of "Small"?
There was a problem hiding this comment.
1 << 20 sounds very large and irrealistic for a lookup set. How about 1 << 10 (which is already quite a lot of lookup strings).
There was a problem hiding this comment.
Well, for more realistic data, how about using std::numeric_limits<Type::c_type>::max() instead?
There was a problem hiding this comment.
We may cut down on the number of benchmark instances and use RangeMultiplier(4) instead.
|
Not too proficient with git so hopefully, I rebased correctly. Added changes as you recommended. |
|
Ok, it seems the git situation is still a bit messed up, I'll fix it up :-) |
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Thank you @david1437 . I'll merge if CI is green.
2 participants
No description provided.