ARROW-10390: [Rust][Parquet] Ensure it is possible to create custom parquet writers #8528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
alamb
changed the title
nevi-me
approved these changes
Oct 26, 2020
Contributor
nevi-me
left a comment
nevi-me
left a comment
There was a problem hiding this comment.
LGTM, just 1 line change
rust/parquet/src/file/writer.rs
Outdated
| // ---------------------------------------------------------------------- | ||
| // Serialized impl for file & row group writers | ||
|
|
||
| pub use crate::util::io::TryClone; |
Contributor
There was a problem hiding this comment.
I'd prefer if the import is still close to line 41. Here it's hidden, especially as a pub use
jorgecarleitao
approved these changes
Oct 26, 2020
Member
jorgecarleitao
left a comment
jorgecarleitao
left a comment
There was a problem hiding this comment.
LGTM. @alamb cargo fmt pls?
sunchao
reviewed
Oct 26, 2020
| @@ -0,0 +1,83 @@ | |||
| use std::fs::File; | |||
rust/parquet/src/file/writer.rs
Outdated
| use crate::util::io::{FileSink, Position, TryClone}; | ||
| use crate::util::io::{FileSink, Position}; | ||
|
|
||
| // Exposed publically so client code can implement ParquetWriter |
Member
There was a problem hiding this comment.
nit: perhaps make ParquetWriter a linked text.
Contributor
Author
|
sunchao
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #8300, it no longer appears possible to implement a
ParquetWriterto provide a custom writer because it is not possible to implement the trait asTryCloneis not publicly exported.This PR publically exports that trait and adds an end to end test demonstrating it is possible to create a custom writer
Here is what happens if you try and use
TryCloneon master