ARROW-10364: [Dev][Archery] Add support for semver 2.13.0 #8501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
force-pushed
the
archery-semver-2.13.0
branch
from
0303f34 to
7d1e824
Compare
Member
|
I didn't see it before applied #8506 which also fixes the issue. |
Member
Author
|
Which approach do you like? |
Contributor
terencehonles
left a comment
terencehonles
left a comment
There was a problem hiding this comment.
Which approach do you like?
Should we close this?
I'll let you both work it out, but just calling out that they should work in tandem and this would fix any potential future string comparisons that are made that aren't covered with the test suite.
Contributor
kou
force-pushed
the
archery-semver-2.13.0
branch
from
7d1e824 to
d6f3258
Compare
Member
Author
|
@kszucs Can I merge this? |
Member
|
Ping @kszucs |
jorgecarleitao
force-pushed
the
master
branch
from
d4608a9 to
356c300
Compare
Member
|
Merging, we'll see if anyone complains :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.