ARROW-10207: [C++] Allow precomputing output string/list offsets in kernels #8498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The main complication here is with the "contiguous preallocation" feature. I'm not sure how much of it is desirable, since if you have a chunked input, you may want it to remain chunked... |
Member
|
Hm, I am not sure whether the contiguous allocation feature is worth the trouble. I'll review this |
pitrou
force-pushed
the
ARROW-10207-kernel-preallocate-offsets
branch
from
622a12b to
183a67a
Compare
pitrou
force-pushed
the
ARROW-10207-kernel-preallocate-offsets
branch
from
183a67a to
17ecfa4
Compare
Member
Author
|
Rebased and fixed conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.