Skip to content

ARROW-10208: [C++] Fix split string kernels on sliced input #8496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pitrou wants to merge 1 commit into from
Closed

ARROW-10208: [C++] Fix split string kernels on sliced input #8496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/src/arrow/compute/kernels/scalar_string.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,8 +923,6 @@ struct SplitBaseTransform {
ListOffsetsBuilderType list_offsets_builder(ctx->memory_pool());
KERNEL_RETURN_IF_ERROR(ctx, list_offsets_builder.Resize(input_nstrings));
ArrayData* output_list = out->mutable_array();
// // we use the same null values
output_list->buffers[0] = input.buffers[0];
// initial value
KERNEL_RETURN_IF_ERROR(
ctx, list_offsets_builder.Append(static_cast<list_offset_type>(0)));
Expand Down Expand Up @@ -986,6 +984,7 @@ struct SplitPatternTransform : SplitBaseTransform<Type, ListType, SplitPatternOp
}
return Status::OK();
}

static bool Find(const uint8_t* begin, const uint8_t* end,
const uint8_t** separator_begin, const uint8_t** separator_end,
const SplitPatternOptions& options) {
Expand All @@ -1004,6 +1003,7 @@ struct SplitPatternTransform : SplitBaseTransform<Type, ListType, SplitPatternOp
}
return false;
}

static bool FindReverse(const uint8_t* begin, const uint8_t* end,
const uint8_t** separator_begin, const uint8_t** separator_end,
const SplitPatternOptions& options) {
Expand Down
6 changes: 2 additions & 4 deletions cpp/src/arrow/compute/kernels/scalar_string_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,10 +339,8 @@ TYPED_TEST(TestStringKernels, SplitBasics) {
// basics
this->CheckUnary("split_pattern", R"(["foo bar", "foo"])", list(this->type()),
R"([["foo", "bar"], ["foo"]])", &options);
// TODO: enable test when the following issue is fixed:
// https://issues.apache.org/jira/browse/ARROW-10208
// this->CheckUnary("split_pattern", R"(["foo bar", "foo", null])", list(this->type()),
// R"([["foo", "bar"], ["foo"], null])", &options);
this->CheckUnary("split_pattern", R"(["foo bar", "foo", null])", list(this->type()),
R"([["foo", "bar"], ["foo"], null])", &options);
// edgy cases
this->CheckUnary("split_pattern", R"(["f o o "])", list(this->type()),
R"([["f", "", "o", "o", ""]])", &options);
Expand Down