ARROW-9963: [Python] Recognize datetime.timezone.utc as UTC on conversion python->pyarrow #8489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jorisvandenbossche python 3.5 build is failing. |
Member
|
Indeed, on Python 3.5, we have: >>> timezone.utc.tzname(None)
'UTC+00:00' |
…sion python->pyarrow
jorisvandenbossche
force-pushed
the
ARROW-9963
branch
2 times, most recently
from
af162f7 to
53aa00b
Compare
jorisvandenbossche
force-pushed
the
ARROW-9963
branch
from
53aa00b to
e31c743
Compare
Member
Author
|
I updated the expected return value for Python 3.5 to still be the former "+00:00" (instead of adding further special cases to the C++ code to "correct" this for python 3.5) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.