Skip to content

ARROW-10332: [Rust] Allow CSV reader to iterate from start up to end #8482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jorgecarleitao wants to merge 6 commits into from
Closed

ARROW-10332: [Rust] Allow CSV reader to iterate from start up to end #8482

jorgecarleitao wants to merge 6 commits into from

Conversation

@jorgecarleitao
Copy link
Member

@jorgecarleitao jorgecarleitao commented Oct 17, 2020

This PR proposes the following changes:

  1. Make the CSV reader accept an optional argument to bound its iteration
  2. Simplify the next code via iterators
  3. Add a new struct to perform buffered iterations (useful to any reader)

@github-actions
Copy link

github-actions bot commented Oct 17, 2020

https://issues.apache.org/jira/browse/ARROW-10332

@jorgecarleitao jorgecarleitao marked this pull request as draft October 17, 2020 08:43
@jorgecarleitao jorgecarleitao marked this pull request as ready for review October 17, 2020 10:57
nevi-me
nevi-me requested changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes and questions. i like the buffered iterator 👍

nevi-me
nevi-me approved these changes Oct 24, 2020
View reviewed changes
Copy link
Contributor

@nevi-me nevi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nevi-me nevi-me closed this in a764d3b Oct 25, 2020
@jorgecarleitao jorgecarleitao deleted the csv_many branch October 28, 2020 04:16
@asfimport asfimport mentioned this pull request Oct 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygrove andygrove andygrove left review comments

@nevi-me nevi-me nevi-me approved these changes

Assignees

No one assigned

Labels

Component: Rust - DataFusion Component: Rust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jorgecarleitao @andygrove @nevi-me