Skip to content

ARROW-10295 [Rust] [DataFusion] Replace Rc<RefCell<>> by Box<> in accumulators. #8456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jorgecarleitao wants to merge 1 commit into from
Closed

ARROW-10295 [Rust] [DataFusion] Replace Rc<RefCell<>> by Box<> in accumulators. #8456

jorgecarleitao wants to merge 1 commit into from

Conversation

@jorgecarleitao
Copy link
Member

@jorgecarleitao jorgecarleitao commented Oct 13, 2020 •
edited
Loading

This PR replaces Rc<RefCell<>> by Box<>. We do not need interior mutability on the accumulations.

@jorgecarleitao jorgecarleitao changed the title ARROW- [Rust] [DataFusion] Replace Rc<RefCell<>> by Box<> in accumulators. ARROW-10295 [Rust] [DataFusion] Replace Rc<RefCell<>> by Box<> in accumulators. Oct 13, 2020
@github-actions
Copy link

github-actions bot commented Oct 13, 2020

https://issues.apache.org/jira/browse/ARROW-10295

andygrove
andygrove approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove andygrove closed this in 818593f Oct 13, 2020
kszucs pushed a commit that referenced this pull request Oct 19, 2020
@jorgecarleitao @kszucs
ARROW-10295 [Rust] [DataFusion] Replace Rc<RefCell<>> by Box<> in acc…
a030fc5 
…umulators.

This PR replaces `Rc<RefCell<>>` by `Box<>`. We do not need interior mutability on the accumulations.

Closes #8456 from jorgecarleitao/box

Authored-by: Jorge C. Leitao <[email protected]>
Signed-off-by: Andy Grove <[email protected]>
@jorgecarleitao jorgecarleitao deleted the box branch October 28, 2020 04:16
@asfimport asfimport mentioned this pull request Jan 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygrove andygrove andygrove approved these changes

Assignees

No one assigned

Labels

Component: Rust - DataFusion Component: Rust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jorgecarleitao @andygrove