ARROW-10289: [Rust] Read dictionaries in IPC streams #8450
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
approved these changes
Oct 13, 2020
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
I didn't do a full review, but it is clear that this is an improvement over the current situation, so LGTM.
kszucs
pushed a commit
that referenced
this pull request
Oct 19, 2020
We were reading dictionaries in the file reader, but not in the stream reader. This was a trivial change, as we needed to add the dictionary to the stream when we encounter it, and then read the next message until we reach a record batch. I tested with the 0.14.1 golden file, I'm going to test with later versions (1.0.0-littleendian) when I get to `arrow::ipc::MetadataVersion::V5` support, hopefully soon. Closes #8450 from nevi-me/ARROW-10289 Authored-by: Neville Dipale <[email protected]> Signed-off-by: Jorge C. Leitao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were reading dictionaries in the file reader, but not in the stream reader.
This was a trivial change, as we needed to add the dictionary to the stream when we encounter it, and then read the next message until we reach a record batch.
I tested with the 0.14.1 golden file, I'm going to test with later versions (1.0.0-littleendian) when I get to
arrow::ipc::MetadataVersion::V5support, hopefully soon.