ARROW-7842: [Rust] [Parquet] Arrow list reader #8449
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevi-me
commented
Oct 12, 2020
Contributor
Author
There was a problem hiding this comment.
@carols10cents when you can, may you please help me out here on these 2 tests that I've ignored?
One needs a LargeList writer implementation, which I think you'd do better than me as you've done roundtrip for other Arrow types.
I've unignored struct_single_column as it's now passing, might be the null comparison commit that fixed it.
Thanks 😃
Contributor
There was a problem hiding this comment.
Looking at this now!
Contributor
There was a problem hiding this comment.
@nevi-me I opened a PR on your repo with some further work -- feel free to cherry pick or whatever, but the tests aren't quite passing yet over there, just failing for a different reason ;)
nevi-me
force-pushed
the
rust-parquet-arrow-writer
branch
from
bd3c714 to
f70e6db
Compare
nevi-me
force-pushed
the
ARROW-7842-cherry
branch
from
ecc49dc to
97d21cf
Compare
nevi-me
force-pushed
the
rust-parquet-arrow-writer
branch
from
f70e6db to
ead5e14
Compare
This is a port of apache#6770 to the parquet-writer branch. We'll have more of a chance to test this reader, and ensure that we can roundtrip on list types. [Rust] [Parquet] LargeListArray support and why I think the tests are still failing (#6) * Support reading LargeListArrays by making ListArrayReader generic over OffsetSize * Update comment to match the actual values in this test; probably copy-paste * Document why I think the test setup isn't quite right disable list writer tests They're failing because of incorrect def/rep. Will be addressed separately
nevi-me
force-pushed
the
ARROW-7842-cherry
branch
from
2afd16d to
485b831
Compare
nevi-me
added a commit
that referenced
this pull request
Oct 17, 2020
This is a port of #6770 to the parquet-writer branch. We'll have more of a chance to test this reader,and ensure that we can roundtrip on list types. Closes #8449 from nevi-me/ARROW-7842-cherry Authored-by: Neville Dipale <[email protected]> Signed-off-by: Neville Dipale <[email protected]>
Contributor
Author
|
Merged |
nevi-me
added a commit
that referenced
this pull request
Oct 25, 2020
This is a port of #6770 to the parquet-writer branch. We'll have more of a chance to test this reader,and ensure that we can roundtrip on list types. Closes #8449 from nevi-me/ARROW-7842-cherry Authored-by: Neville Dipale <[email protected]> Signed-off-by: Neville Dipale <[email protected]>
nevi-me
added a commit
that referenced
this pull request
Oct 27, 2020
This is a port of #6770 to the parquet-writer branch. We'll have more of a chance to test this reader,and ensure that we can roundtrip on list types. Closes #8449 from nevi-me/ARROW-7842-cherry Authored-by: Neville Dipale <[email protected]> Signed-off-by: Neville Dipale <[email protected]>
nevi-me
added a commit
that referenced
this pull request
Oct 28, 2020
This is a port of #6770 to the parquet-writer branch. We'll have more of a chance to test this reader,and ensure that we can roundtrip on list types. Closes #8449 from nevi-me/ARROW-7842-cherry Authored-by: Neville Dipale <[email protected]> Signed-off-by: Neville Dipale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of #6770 to the parquet-writer branch.
We'll have more of a chance to test this reader,and ensure that we can roundtrip on list types.