Skip to content

ARROW-10256: [C++][Flight] Disable -Werror carefully #8419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kou wants to merge 3 commits into from
Closed

ARROW-10256: [C++][Flight] Disable -Werror carefully #8419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e3277e
[C++][Flight] Disable -Werror carefully
kou Oct 9, 2020
953af85
Disable S3 because it's fragile on GitHub Actions and Travis CI
kou Oct 10, 2020
20a2949
Fix shell redirect syntax
kou Oct 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/build-support/run-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ function run_test() {
# even when retries are successful.
rm -f $XMLFILE

$TEST_EXECUTABLE "$@" 2>&1 $LOGFILE.raw
$TEST_EXECUTABLE "$@" > $LOGFILE.raw 2>&1
STATUS=$?
cat $LOGFILE.raw \
| ${PYTHON:-python} $ROOT/build-support/asan_symbolize.py \
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/flight/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ add_custom_target(flight_grpc_gen ALL DEPENDS ${FLIGHT_GENERATED_PROTO_FILES})
# way to pass -isystem $GRPC_INCLUDE_DIR instead of -I$GRPC_INCLUDE_DIR
set(CMAKE_CXX_FLAGS_BACKUP "${CMAKE_CXX_FLAGS}")
string(REPLACE "/WX" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
string(REPLACE "-Werror" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
string(REPLACE "-Werror " " " CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")

# Probe the version of gRPC being used to see if it supports disabling server
# verification when using TLS.
Expand Down
5 changes: 4 additions & 1 deletion dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@
%define use_gandiva (%{_centos_ver} >= 8 && %{_arch} != "aarch64")
%define use_ninja (%{_centos_ver} >= 8)
%define use_parquet (%{_centos_ver} >= 7)
%define use_s3 (%{_centos_ver} >= 8)
# TODO: Enable this. This works on local but is fragile on GitHub Actions and
# Travis CI.
# %define use_s3 (%{_centos_ver} >= 8)
%define use_s3 0

%define use_glib (%{_centos_ver} >= 7)
%define use_meson (%{_centos_ver} >= 8)
Expand Down