Skip to content

ARROW-10204: [Rust] Filter kernel should only count bits in valid range #8378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jhorstmann wants to merge 2 commits into from
Closed

ARROW-10204: [Rust] Filter kernel should only count bits in valid range #8378

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddc8e83
ARROW-10204 Count only bits in valid range
jhorstmann Oct 7, 2020
ac2de5b
ARROW-10204 Formatting
jhorstmann Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rust/arrow/src/compute/kernels/filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,8 @@ impl FilterContext {
}
let filter_mask: Vec<u64> = (0..64).map(|x| 1u64 << x).collect();
let filter_bytes = filter_array.data_ref().buffers()[0].data();
let filtered_count = bit_util::count_set_bits(filter_bytes);
let filtered_count =
bit_util::count_set_bits_offset(filter_bytes, 0, filter_array.len());

// transmute filter_bytes to &[u64]
let mut u64_buffer = MutableBuffer::new(filter_bytes.len());
Expand Down