Skip to content

ARROW-10176: [C++] Avoid using unformattable types for test parameters #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bkietz wants to merge 1 commit into from
Closed

ARROW-10176: [C++] Avoid using unformattable types for test parameters #8369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions cpp/src/parquet/reader_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,13 +514,9 @@ TEST(TestFileReader, BufferedReads) {
}
}

struct CodecTestParam {
std::string data_file;
};

class TestCodec : public ::testing::TestWithParam<CodecTestParam> {
class TestCodec : public ::testing::TestWithParam<std::string> {
protected:
const std::string& GetDataFile() { return GetParam().data_file; }
const std::string& GetDataFile() { return GetParam(); }
};

TEST_P(TestCodec, FileMetadataAndValues) {
Expand Down Expand Up @@ -555,8 +551,8 @@ TEST_P(TestCodec, FileMetadataAndValues) {

#ifdef ARROW_WITH_LZ4
INSTANTIATE_TEST_SUITE_P(Lz4CodecTests, TestCodec,
::testing::Values(CodecTestParam{hadoop_lz4_compressed()},
CodecTestParam{non_hadoop_lz4_compressed()}));
::testing::Values(hadoop_lz4_compressed(),
non_hadoop_lz4_compressed()));
#endif

} // namespace parquet