ARROW-9943: [C++] Recursively apply Arrow metadata when reading from Parquet #8366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
commented
Oct 6, 2020
cpp/src/parquet/arrow/schema.cc
Outdated
Member
Author
There was a problem hiding this comment.
@emkornfield I think you'll be able to add your changes here.
pitrou
force-pushed
the
ARROW-9943-parquet-nested-metadata
branch
from
bbf193f to
289fb9c
Compare
Member
Author
|
Also cc @jorisvandenbossche |
…Parquet This allows roundtripping complex types such as `list<dictionary<utf8>>`, `list<extension>`, etc.
pitrou
force-pushed
the
ARROW-9943-parquet-nested-metadata
branch
from
289fb9c to
6673a8a
Compare
bkietz
previously requested changes
Oct 6, 2020
emkornfield
reviewed
Oct 7, 2020
| if (origin_type.id() == ::arrow::Type::LIST) { | ||
| return RewrapListField; | ||
| return [](FieldVector fields) { | ||
| DCHECK_EQ(fields.size(), 1); |
Contributor
There was a problem hiding this comment.
Can a schema be deserialized that has more then 1 field? i.e. should this return a user space error instead?
Member
Author
There was a problem hiding this comment.
Normally no, because we already checked that origin_type->num_fields() == inferred_type->num_fields().
emkornfield
reviewed
Oct 7, 2020
emkornfield
reviewed
Oct 7, 2020
emkornfield
reviewed
Oct 7, 2020
Member
Author
|
Will merge if CI green. Thank you for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows roundtripping complex types such as
list<dictionary<utf8>>,list<extension>, etc.