Skip to content

ARROW-10139: [C++] Add support for building arrow_testing without building tests #8356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kou wants to merge 1 commit into from
Closed

ARROW-10139: [C++] Add support for building arrow_testing without building tests #8356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,7 @@ if(ARROW_BUILD_BENCHMARKS
OR ARROW_BUILD_INTEGRATION
OR ARROW_FUZZING)
set(ARROW_JSON ON)
set(ARROW_TESTING ON)
endif()

if(ARROW_CUDA
Expand Down
2 changes: 2 additions & 0 deletions cpp/cmake_modules/DefineOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,8 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")

define_option(ARROW_TENSORFLOW "Build Arrow with TensorFlow support enabled" OFF)

define_option(ARROW_TESTING "Build the Arrow testing libraries" OFF)

#----------------------------------------------------------------------
set_option_category("Thirdparty toolchain")

Expand Down
5 changes: 1 addition & 4 deletions cpp/cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1647,10 +1647,7 @@ macro(build_gtest)
add_dependencies(GTest::gmock googletest_ep)
endmacro()

if(ARROW_BUILD_TESTS
OR ARROW_BUILD_BENCHMARKS
OR ARROW_BUILD_INTEGRATION
OR ARROW_FUZZING)
if(ARROW_TESTING)
resolve_dependency(GTest)

if(NOT GTEST_VENDORED)
Expand Down
6 changes: 1 addition & 5 deletions cpp/src/arrow/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,11 +530,7 @@ if(ARROW_BUILD_STATIC AND ARROW_BUNDLED_STATIC_LIBS)
${_OTHER_LIBS})
endif()

if(ARROW_BUILD_TESTS
OR ARROW_BUILD_BENCHMARKS
OR ARROW_BUILD_INTEGRATION
OR ARROW_FUZZING)

if(ARROW_TESTING)
# that depend on gtest
add_arrow_lib(arrow_testing
CMAKE_PACKAGE_NAME
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/flight/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ foreach(LIB_TARGET ${ARROW_FLIGHT_LIBRARIES})
endforeach()

# Define arrow_flight_testing library
if(ARROW_BUILD_TESTS OR ARROW_BUILD_BENCHMARKS OR ARROW_BUILD_INTEGRATION)
if(ARROW_TESTING)
add_arrow_lib(arrow_flight_testing
CMAKE_PACKAGE_NAME
ArrowFlightTesting
Expand Down