-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-10178: [CI] Remove patch to fix Spark master build #8352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-10178: [CI] Remove patch to fix Spark master build #8352
Conversation
|
@ursabot crossbow submit test-conda-python-3.8-spark-master |
|
AMD64 Conda Crossbow Submit (#131023) builder has been succeeded. Revision: 7c62c5b Submitted crossbow builds: ursa-labs/crossbow @ ursabot-582
|
|
I think we might have to add a patch to fix that nested timezone problem from earlier in #7804 , but lets see how the integration run goes |
|
Spark needs to be patched again to handle structs with timestamps, adding the patch here and it can be removed after SPARK-32285 is complete. This is due to the changes in #7816 |
|
@ursabot crossbow submit test-conda-python-3.8-spark-master |
|
AMD64 Conda Crossbow Submit (#131422) builder has been succeeded. Revision: ed31bb2 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-583
|
|
@kszucs the Spark integration tests are passing for master branch with this change, could you take a look? Thanks! |
Was this patch necessary before? I thought we should be running Spark in a backwards compatibility mode that doesn't honor the TZ info. (maybe this got dropped from the patch?) |
This reverts commit ed31bb2.
|
Oh, I didn't see there was a backwards compatible setting. I ran the tests locally and obviously failed without it. Let me remove the patch and run again here. |
|
@ursabot crossbow submit test-conda-python-3.8-spark-master |
|
AMD64 Conda Crossbow Submit (#131560) builder has been succeeded. Revision: 6a064e5 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-584
|
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Thanks Bryan! |
Spark master branch has been updated for Arrow 1.0.1, the patch to fix Java compilation can be removed.