Skip to content

Conversation

@pgovind
Copy link

@pgovind pgovind commented Oct 5, 2020

Fix for https://issues.apache.org/jira/browse/ARROW-6972

Add support for StructArray. It'd be nice to have an easier way to construct a StructArray, but that can come in a follow up PR.

cc @eerhardt @nealrichardson
Not sure who else works on the C# parts of the repo.

@github-actions
Copy link

github-actions bot commented Oct 5, 2020

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@pgovind pgovind changed the title C# support for StructArrays ARROW-6972: [C#] C# support for StructArrays Oct 5, 2020
@github-actions
Copy link

github-actions bot commented Oct 5, 2020

Copy link
Contributor

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good. Thanks for the quick turnaround on this.

@kou kou changed the title ARROW-6972: [C#] C# support for StructArrays ARROW-6972: [C#] Support for StructArrays Oct 5, 2020
Prashanth Govindarajan and others added 4 commits October 5, 2020 17:24
- Fill out StructArray.Fields with correct data
- NestedType.Children => Fields to match C++ naming
- Add back StructType.GetFieldIndex and add tests
- Minor code formatting
Copy link
Contributor

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @pgovind for getting this feature in.

I'll merge this early tomorrow if there is no more feedback.

@eerhardt
Copy link
Contributor

eerhardt commented Oct 7, 2020

@kou @nealrichardson - do you know why the assign-rust-labels job failed?

1s
Run actions/[email protected]
  with:
    repo-token: ***
    configuration-path: .github/workflows/dev_labeler/labeler.yml
    sync-labels: true
Error: TypeError: glob pattern string required
Error: glob pattern string required

@nealrichardson
Copy link
Member

@eerhardt I haven't looked but I think the authors of that new workflow are working to fix it. You can ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants