-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-6972: [C#] Support for StructArrays #8348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
eerhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good. Thanks for the quick turnaround on this.
- Fill out StructArray.Fields with correct data - NestedType.Children => Fields to match C++ naming - Add back StructType.GetFieldIndex and add tests - Minor code formatting
eerhardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @pgovind for getting this feature in.
I'll merge this early tomorrow if there is no more feedback.
|
@kou @nealrichardson - do you know why the assign-rust-labels job failed? |
|
@eerhardt I haven't looked but I think the authors of that new workflow are working to fix it. You can ignore it. |
Fix for https://issues.apache.org/jira/browse/ARROW-6972
Add support for
StructArray. It'd be nice to have an easier way to construct aStructArray, but that can come in a follow up PR.cc @eerhardt @nealrichardson
Not sure who else works on the C# parts of the repo.