Skip to content

Conversation

@jorgecarleitao
Copy link
Member

@kszucs @nevi-me @andygrove @paddyhoran what do you think about this? (please tag others if relevant)

The idea being:

  • PRs that change code in rust/ are labeled rust-lang
  • PRs that change code in rust/datafusion are labeled datafusion

The problems it solves:

  • it is currently difficult to filter PRs by component, as we cannot bookmark a view for that filter
  • It is currently difficult to find the component in the title (than it is to find on labels, due to the coloring)
  • PRs may change code in rust/ even though it is not labeled as such, and folks in Rust would probably like to know about it

Since @andygrove has been adding labels, I though that we could automatize it as an action.

I did not expand to other labels as I am not sure other parts use github labels at all.

@github-actions
Copy link

github-actions bot commented Oct 2, 2020

@kou
Copy link
Member

kou commented Oct 2, 2020

I think that dev_cron.yml isn't suitable.
Jobs in it run periodically.

How about using pull_request_target instead like https://github.com/actions/labeler#create-workflow ?

@jorgecarleitao
Copy link
Member Author

I agree @kou that dev_cron is not suitable atm and I though about a new flow. However, looking at the current jobs there, I think that they can all be migrated to a different on, since they can all be triggered by events, instead of a schedule.

So, my plan was to PR a migration of that dev_cron to be triggered by events, like you suggest. Does this make sense?

@kou
Copy link
Member

kou commented Oct 2, 2020

Do you want to change on in dev_cron.yml?
I don't think that it's a good idea. If we don't use schedule, it's not CRON.

How about creating a new workflow file such as .github/workflows/dev_pull_request.yml or something and putting only this job to the new workflow file?

Other existing jobs (jira-link and title-check) can be migrated to pull_request_target from schedule but we need to change .github/workflows/dev_cron/*.js logic. We can work on it as a follow-up task.

@andygrove
Copy link
Member

@jorgecarleitao I will be very happy to relinquish my role as github label admin (as I'm sure the other Rust committers will too). Thanks for working on this.

@jorgecarleitao
Copy link
Member Author

jorgecarleitao commented Oct 2, 2020

@kou, Thanks for the suggestion. I have moved the content to another place and added the on accordingly.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kszucs What do you think about this file name (dev_labelar) ?

@jorgecarleitao
Copy link
Member Author

FYI @lidavidm (lang-java) and @romainfrancois (lang-R), since both of you are also tagging PRs with github labels.

@kszucs
Copy link
Member

kszucs commented Oct 5, 2020

@kszucs What do you think about this file name (dev_labelar) ?

We organize the gha configurations based on "language" and event. Based on that we have the option to name it dev_pull_request_target.yml but the pull_request_target event name is so misleading that I'd rather keep dev_labeler.yml since it's much more descriptive. Once we have more actions triggered on this event we can find a better name.

@kou
Copy link
Member

kou commented Oct 5, 2020

OK.
I'll merge this.

@kou kou closed this in bb553c4 Oct 5, 2020
@asfimport asfimport mentioned this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants