Skip to content

ARROW-4927: [Rust] Update top level README to describe current functionality #8313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jorgecarleitao wants to merge 4 commits into from
Closed

ARROW-4927: [Rust] Update top level README to describe current functionality #8313

jorgecarleitao wants to merge 4 commits into from

Conversation

@jorgecarleitao
Copy link
Member

@jorgecarleitao jorgecarleitao commented Sep 30, 2020

Updates the top level README with more details about the crates, their current functionality, and what they enable.

@github-actions
Copy link

github-actions bot commented Sep 30, 2020

https://issues.apache.org/jira/browse/ARROW-4927

alamb
alamb approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the doc and checked the links. It looked good to me. 👍

In case anyone else wants to see a rendered version of this markdown, I found I could see one easily at https://github.com/jorgecarleitao/arrow/tree/doc-base/rust

andygrove
andygrove approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgecarleitao
Copy link
Member Author

jorgecarleitao commented Oct 2, 2020

Actually, I had to create both versions, as they won't really work for sub-projects now.

@andygrove
Copy link
Member

andygrove commented Oct 2, 2020

@jorgecarleitao Now that you are a committer do you want to merge this one to get to know the process? I usually make sure I have the latest from the master branch and then run ./dev/merge_pr.py.

@jorgecarleitao
Copy link
Member Author

jorgecarleitao commented Oct 2, 2020

@andygrove , sure! I am stuck in the last step of https://gitbox.apache.org/setup/

User not a member of the ASF GitHub organisation. Please make sure you are a part of the ASF Organisation on GitHub and have 2FA enabled. Visit id.apache.org and set your GitHub ID to be invited to the org.

@jorgecarleitao jorgecarleitao deleted the doc-base branch October 3, 2020 21:07
@jorgecarleitao
Copy link
Member Author

jorgecarleitao commented Oct 3, 2020

@andygrove , I was now able to merge this. First commit 🎉

@asfimport asfimport mentioned this pull request Oct 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

@andygrove andygrove andygrove approved these changes

Assignees

No one assigned

Labels

Component: Rust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jorgecarleitao @andygrove @alamb