-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-9898: [C++][Gandiva] Fix linking issue with castINT/FLOAT functions #8096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #include "gandiva/gdv_function_stubs.h" | ||
|
|
||
| #include <gmock/gmock.h> | ||
| #include <gtest/gtest.h> | ||
|
|
||
| #include "gandiva/execution_context.h" | ||
|
|
||
| namespace gandiva { | ||
|
|
||
| TEST(TestGdvFnStubs, TestCastINT) { | ||
| gandiva::ExecutionContext ctx; | ||
|
|
||
| int64_t ctx_ptr = reinterpret_cast<int64_t>(&ctx); | ||
|
|
||
| EXPECT_EQ(gdv_fn_castINT_utf8(ctx_ptr, "-45", 3), -45); | ||
| EXPECT_EQ(gdv_fn_castINT_utf8(ctx_ptr, "0", 1), 0); | ||
| EXPECT_EQ(gdv_fn_castINT_utf8(ctx_ptr, "2147483647", 10), 2147483647); | ||
| EXPECT_EQ(gdv_fn_castINT_utf8(ctx_ptr, "02147483647", 11), 2147483647); | ||
| EXPECT_EQ(gdv_fn_castINT_utf8(ctx_ptr, "-2147483648", 11), -2147483648LL); | ||
| EXPECT_EQ(gdv_fn_castINT_utf8(ctx_ptr, "-02147483648", 12), -2147483648LL); | ||
| EXPECT_EQ(gdv_fn_castINT_utf8(ctx_ptr, " 12 ", 4), 12); | ||
|
|
||
| gdv_fn_castINT_utf8(ctx_ptr, "2147483648", 10); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string 2147483648 to int32")); | ||
| ctx.Reset(); | ||
|
|
||
| gdv_fn_castINT_utf8(ctx_ptr, "-2147483649", 11); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string -2147483649 to int32")); | ||
| ctx.Reset(); | ||
|
|
||
| gdv_fn_castINT_utf8(ctx_ptr, "12.34", 5); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string 12.34 to int32")); | ||
| ctx.Reset(); | ||
|
|
||
| gdv_fn_castINT_utf8(ctx_ptr, "abc", 3); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string abc to int32")); | ||
| ctx.Reset(); | ||
|
|
||
| gdv_fn_castINT_utf8(ctx_ptr, "", 0); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string to int32")); | ||
| ctx.Reset(); | ||
|
|
||
| gdv_fn_castINT_utf8(ctx_ptr, "-", 1); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string - to int32")); | ||
| ctx.Reset(); | ||
| } | ||
|
|
||
| TEST(TestGdvFnStubs, TestCastBIGINT) { | ||
| gandiva::ExecutionContext ctx; | ||
|
|
||
| int64_t ctx_ptr = reinterpret_cast<int64_t>(&ctx); | ||
|
|
||
| EXPECT_EQ(gdv_fn_castBIGINT_utf8(ctx_ptr, "-45", 3), -45); | ||
| EXPECT_EQ(gdv_fn_castBIGINT_utf8(ctx_ptr, "0", 1), 0); | ||
| EXPECT_EQ(gdv_fn_castBIGINT_utf8(ctx_ptr, "9223372036854775807", 19), | ||
| 9223372036854775807LL); | ||
| EXPECT_EQ(gdv_fn_castBIGINT_utf8(ctx_ptr, "09223372036854775807", 20), | ||
| 9223372036854775807LL); | ||
| EXPECT_EQ(gdv_fn_castBIGINT_utf8(ctx_ptr, "-9223372036854775808", 20), | ||
| -9223372036854775807LL - 1); | ||
| EXPECT_EQ(gdv_fn_castBIGINT_utf8(ctx_ptr, "-009223372036854775808", 22), | ||
| -9223372036854775807LL - 1); | ||
| EXPECT_EQ(gdv_fn_castBIGINT_utf8(ctx_ptr, " 12 ", 4), 12); | ||
|
|
||
| gdv_fn_castBIGINT_utf8(ctx_ptr, "9223372036854775808", 19); | ||
| EXPECT_THAT( | ||
| ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string 9223372036854775808 to int64")); | ||
| ctx.Reset(); | ||
|
|
||
| gdv_fn_castBIGINT_utf8(ctx_ptr, "-9223372036854775809", 20); | ||
| EXPECT_THAT( | ||
| ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string -9223372036854775809 to int64")); | ||
| ctx.Reset(); | ||
|
|
||
| gdv_fn_castBIGINT_utf8(ctx_ptr, "12.34", 5); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string 12.34 to int64")); | ||
| ctx.Reset(); | ||
|
|
||
| gdv_fn_castBIGINT_utf8(ctx_ptr, "abc", 3); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string abc to int64")); | ||
| ctx.Reset(); | ||
|
|
||
| gdv_fn_castBIGINT_utf8(ctx_ptr, "", 0); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string to int64")); | ||
| ctx.Reset(); | ||
|
|
||
| gdv_fn_castBIGINT_utf8(ctx_ptr, "-", 1); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string - to int64")); | ||
| ctx.Reset(); | ||
| } | ||
|
|
||
| TEST(TestGdvFnStubs, TestCastFloat4) { | ||
| gandiva::ExecutionContext ctx; | ||
|
|
||
| int64_t ctx_ptr = reinterpret_cast<int64_t>(&ctx); | ||
|
|
||
| EXPECT_EQ(gdv_fn_castFLOAT4_utf8(ctx_ptr, "-45.34", 6), -45.34f); | ||
| EXPECT_EQ(gdv_fn_castFLOAT4_utf8(ctx_ptr, "0", 1), 0.0f); | ||
| EXPECT_EQ(gdv_fn_castFLOAT4_utf8(ctx_ptr, "5", 1), 5.0f); | ||
| EXPECT_EQ(gdv_fn_castFLOAT4_utf8(ctx_ptr, " 3.4 ", 5), 3.4f); | ||
|
|
||
| gdv_fn_castFLOAT4_utf8(ctx_ptr, "", 0); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string to float")); | ||
| ctx.Reset(); | ||
|
|
||
| gdv_fn_castFLOAT4_utf8(ctx_ptr, "e", 1); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string e to float")); | ||
| ctx.Reset(); | ||
| } | ||
|
|
||
| TEST(TestGdvFnStubs, TestCastFloat8) { | ||
| gandiva::ExecutionContext ctx; | ||
|
|
||
| int64_t ctx_ptr = reinterpret_cast<int64_t>(&ctx); | ||
|
|
||
| EXPECT_EQ(gdv_fn_castFLOAT8_utf8(ctx_ptr, "-45.34", 6), -45.34); | ||
| EXPECT_EQ(gdv_fn_castFLOAT8_utf8(ctx_ptr, "0", 1), 0.0); | ||
| EXPECT_EQ(gdv_fn_castFLOAT8_utf8(ctx_ptr, "5", 1), 5.0); | ||
| EXPECT_EQ(gdv_fn_castFLOAT8_utf8(ctx_ptr, " 3.4 ", 5), 3.4); | ||
|
|
||
| gdv_fn_castFLOAT8_utf8(ctx_ptr, "", 0); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string to double")); | ||
| ctx.Reset(); | ||
|
|
||
| gdv_fn_castFLOAT8_utf8(ctx_ptr, "e", 1); | ||
| EXPECT_THAT(ctx.get_error(), | ||
| ::testing::HasSubstr("Failed to cast the string e to double")); | ||
| ctx.Reset(); | ||
| } | ||
|
|
||
| } // namespace gandiva |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we make this an external function only for this message? whats the perf penalty for doing this..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really for this message. As you can see from attached commits earlier I removed the std::stiring from error path in castInt, but the castInt function also started failing after this commit 8041ae5 (for the same reason as castFloat); earlier there was no dependency so it worked. Since it is not a header only library, we need to either compile all the dependent cc files, along with the precompiled functions, to llvm bit code; or move this function to a stub function. I think its better to move it to a stub function since the dependencies may change.