-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI #7938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.travis.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needless because we don't use Ubuntu based docker image.
.travis.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needless because ARCH is already passed as environment variable.
.travis.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using a common script for all jobs like the following?
diff --git a/.travis.yml b/.travis.yml
index fa5d84c82..551d0a029 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -47,15 +47,23 @@ jobs:
env:
ARCH: s390x
ARROW_CI_MODULES: "CPP"
- ARROW_FLIGHT: "ON"
- ARROW_PARQUET: "OFF"
DOCKER_IMAGE_ID: ubuntu-cpp
- PARQUET_BUILD_EXAMPLES: "OFF"
- PARQUET_BUILD_EXECUTABLES: "OFF"
- Protobuf_SOURCE: "BUNDLED"
+ DOCKER_RUN_ARGS: >-
+ -e ARROW_FLIGHT=ON
+ -e ARROW_PARQUET=OFF
+ -e PARQUET_BUILD_EXAMPLES=OFF
+ -e PARQUET_BUILD_EXECUTABLES=OFF
+ -e Protobuf_SOURCE=BUNDLED
+ -e cares_SOURCE=BUNDLED
+ -e gRPC_SOURCE=BUNDLED
UBUNTU: "20.04"
- cares_SOURCE: "BUNDLED"
- gRPC_SOURCE: "BUNDLED"
+ - name: "Java on s390x"
+ os: linux
+ arch: s390x
+ env:
+ ARCH: s390x
+ ARROW_CI_MODULES: "JAVA"
+ DOCKER_IMAGE_ID: debian-java
allow_failures:
- arch: s390x
@@ -89,13 +97,7 @@ script:
ulimit -c unlimited || :
- |
archery docker run \
- -e ARROW_FLIGHT=${ARROW_FLIGHT:-OFF} \
- -e ARROW_PARQUET=${ARROW_PARQUET:-ON} \
- -e PARQUET_BUILD_EXAMPLES=${PARQUET_BUILD_EXAMPLES:-ON} \
- -e PARQUET_BUILD_EXECUTABLES=${PARQUET_BUILD_EXECUTABLES:-ON} \
- -e Protobuf_SOURCE=${Protobuf_SOURCE:-} \
- -e cares_SOURCE=${cares_SOURCE:-} \
- -e gRPC_SOURCE=${gRPC_SOURCE:-} \
+ ${DOCKER_RUN_ARGS} \
--volume ${PWD}/build:/build \
${DOCKER_IMAGE_ID}
ci/scripts/java_build.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| grp="com.github.icexelloss" | |
| group="com.github.icexelloss" |
ci/scripts/java_build.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| cls="linux-s390_64" | |
| classifier="linux-s390_64" |
ci/scripts/java_build.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, $(...) is preferred than `...`:
| ${mvn_install} -DgroupId=${grp} -DartifactId=${artifact} -Dversion=${ver} -Dpackaging=${extension} -Dfile=`pwd`/${target} | |
| ${mvn_install} -DgroupId=${grp} -DartifactId=${artifact} -Dversion=${ver} -Dpackaging=${extension} -Dfile=$(pwd)/${target} |
ffbb910 to
6fd6dac
Compare
|
@kou Thank you. Now, a TravisCI job is finished correctly with many failures. Could you review this again? |
ci/scripts/java_build.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove -Dmaven.compiler.verbose=true and remove the else clause?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, done
java/pom.xml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, use the original setting. Done
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
We hold off merging this until we come to consensus on https://lists.apache.org/thread.html/r3d4ab3ccc8db7a7a68baa727bf9b6911930b61609c0faaed14e2b773%40%3Cdev.arrow.apache.org%3E .
See also: #8047 (comment)
|
@emkornfield @kou Is it ok to merge this PR now? Or, do we still hold off for a while? |
|
Yes, I think so. I'd still like to update the contributor guidelines to make it clear what the level of support we are aiming for in each language (I hope to get to it tonight but if I don't it might take me a few days), but I think CI should be harmless. @kou it looks like you are happy with this PR? |
|
Yes. |
|
@emkornfield @kou Thank you. I want to merge only this PR for CI. We should still hold off other PRs. I rebased with master branch and confirmed it works well. |
|
Thanks. |
This is a follow-up of #7938. #7938 forgot downloading a required dll `libprotobuf.so.18` at the build time. Closes #8368 from kiszk/ARROW-10200 Authored-by: Kazuaki Ishizaki <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
This PR adds a new test job for big-endian Java environment to TravisCI. It still keeps as