Skip to content

ARROW-9604: [C++] Add aggregate min/max benchmark #7870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frankdjx wants to merge 2 commits into from
Closed

ARROW-9604: [C++] Add aggregate min/max benchmark #7870

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18ced4a
Add MinMax kernel benchmark.
frankdjx Aug 12, 2020
0b9de25
Remove meaningless Count benchmark (it's a trivial constant-time oper…
pitrou Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions cpp/src/arrow/compute/kernels/aggregate_benchmark.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,5 +369,34 @@ MODE_KERNEL_BENCHMARK(ModeKernelInt16, Int16Type);
MODE_KERNEL_BENCHMARK(ModeKernelInt32, Int32Type);
MODE_KERNEL_BENCHMARK(ModeKernelInt64, Int64Type);

template <typename ArrowType>
static void MinMaxKernelBench(benchmark::State& state) {
using CType = typename TypeTraits<ArrowType>::CType;

RegressionArgs args(state);
const int64_t array_size = args.size / sizeof(CType);
auto rand = random::RandomArrayGenerator(1923);
auto array = rand.Numeric<ArrowType>(array_size, -100, 100, args.null_proportion);

for (auto _ : state) {
ABORT_NOT_OK(MinMax(array).status());
}
}

static void MinMaxKernelBenchArgs(benchmark::internal::Benchmark* bench) {
BenchmarkSetArgsWithSizes(bench, {1 * 1024 * 1024}); // 1M
}

#define MINMAX_KERNEL_BENCHMARK(FuncName, Type) \
static void FuncName(benchmark::State& state) { MinMaxKernelBench<Type>(state); } \
BENCHMARK(FuncName)->Apply(MinMaxKernelBenchArgs)

MINMAX_KERNEL_BENCHMARK(MinMaxKernelFloat, FloatType);
MINMAX_KERNEL_BENCHMARK(MinMaxKernelDouble, DoubleType);
MINMAX_KERNEL_BENCHMARK(MinMaxKernelInt8, Int8Type);
MINMAX_KERNEL_BENCHMARK(MinMaxKernelInt16, Int16Type);
MINMAX_KERNEL_BENCHMARK(MinMaxKernelInt32, Int32Type);
MINMAX_KERNEL_BENCHMARK(MinMaxKernelInt64, Int64Type);

} // namespace compute
} // namespace arrow