ARROW-9475: [Java] Clean up usages of BaseAllocator, use BufferAllocator in… #7768
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
|
This patch is also supposed to be a dependency of #7030 (ARROW-7808). |
zhztheplayer
changed the title
rymurr
left a comment
rymurr
left a comment
There was a problem hiding this comment.
Looks good to me, one comment about the allocate/release additions. Otherwise its great to further limit BaseAllocators visibility
| * @param size to increase | ||
| * @return Whether the allocation fit within limits. | ||
| */ | ||
| boolean forceAllocate(long size); |
There was a problem hiding this comment.
I didn't see where this or releaseBytes are used in code. What is the purpose of releaseBytes and of makign forceAllocate public
There was a problem hiding this comment.
Hi @rymurr,
E.g. Please see the changes such as
The uses of BufferAllocator requires for having the relevant methods extracted up to interface.
|
@jacques-n Could you please talk a look? Thanks. For ARROW-7808, having this one solved we could be able to leave customized AllocationManager implementation out of the package |
|
+1 |
…tor in… …stead Issue link: https://issues.apache.org/jira/browse/ARROW-9475. Closes #7768 from zhztheplayer/ARROW-9475 Authored-by: Hongze Zhang <[email protected]> Signed-off-by: Micah Kornfield <[email protected]>
…tor in… …stead Issue link: https://issues.apache.org/jira/browse/ARROW-9475. Closes apache#7768 from zhztheplayer/ARROW-9475 Authored-by: Hongze Zhang <[email protected]> Signed-off-by: Micah Kornfield <[email protected]>
3 participants
…stead
Issue link: https://issues.apache.org/jira/browse/ARROW-9475.