ARROW-7285: [C++] ensure C++ implementation meets clarified dictionary spec #7544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@liyafan82 I'm assuming this is work-in-progress? I can give it a quick review anyway. |
liyafan82
force-pushed
the
fly_0619_ipc
branch
6 times, most recently
from
636927d to
f1183b6
Compare
Contributor
Author
|
@pitrou Thanks a lot for your attention. |
liyafan82
force-pushed
the
fly_0619_ipc
branch
2 times, most recently
from
a9717d3 to
a5c718d
Compare
pitrou
requested changes
Jun 30, 2020
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Thank you for doing this! This is a welcome improvement.
liyafan82
force-pushed
the
fly_0619_ipc
branch
2 times, most recently
from
5fe3fd7 to
c1d89ba
Compare
pitrou
approved these changes
Jul 1, 2020
Member
|
Thanks for the update. I will merge this PR once CI is green. |
Contributor
Author
|
@pitrou Thanks a lot for your effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/ARROW-7285