-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-8225: [Rust] Continuation marker check was in wrong location. #6791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
|
Hm; these errors popped up but I'm not sure why they're happening? Is the trunk broken? |
#6800 will fix the issue |
|
@maxburke do you perhaps have an example to help me understand the continuation issue? I haven't read the spec in a few weeks/months |
|
@nevi-me https://arrow.apache.org/docs/format/Columnar.html |
|
@nevi-me I think your original IPC implementation was based on 0.14, right before this change was adopted. |
nevi-me
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've now seen the change from 0.15.0, and understand what this change achieves
In the previous commit I had the continuation marker check in the wrong location.