ARROW-7636: [Python] Clean-up the pyarrow.dataset.partitioning() API #6244
Conversation
| the schema will be inferred from the file path (and a | ||
| PartitioningFactory is returned). | ||
| field_names : list of str, default None | ||
| A list of strings (field names). If specified, the schema's types are |
There was a problem hiding this comment.
@bkietz @kszucs following up on #6022 (comment), I went with splitting the keyword into two separate ones.
But I can also rename it to schema_or_field_names and keep it as a single one (it's long, but you can use it positionally), if that has stronger preference.
I think having separate ones is a bit cleaner, and easier to explain.
There was a problem hiding this comment.
And it is easier to merge than separate later.
| if isinstance(schema, pa.Schema): | ||
| return HivePartitioning(schema) | ||
| else: | ||
| raise ValueError( |
There was a problem hiding this comment.
This is why I found useful the ability to restrict the HivePartitioning for certain field names. Perhaps I'm only interested in a subset of the partitioning fields, and it'd be easier to define them here.
@bkietz created an issue where we can discuss https://issues.apache.org/jira/browse/ARROW-7646
2 participants
No description provided.