ARROW-7021: [Java] UnionFixedSizeListWriter decimal type should check writer index #5802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkornfield
reviewed
Nov 12, 2019
emkornfield
reviewed
Nov 12, 2019
java/vector/src/test/java/org/apache/arrow/vector/TestFixedSizeListVector.java
Outdated
Show resolved
Hide resolved
emkornfield
reviewed
Nov 15, 2019
| } | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
it doesn't look like there is a check to ensure writing succeeds? could you also add one here?
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
… writer index Related to [ARROW-7021](https://issues.apache.org/jira/browse/ARROW-7021). UnionFixedSizeListWriter should check writer index for decimal type (just as other types) to ensure the values written not exceed listSize. Otherwise, the writer may continue to write data into it’s underlying vector quietly even the the writer.idx() > listSize * index. Closes apache#5802 from tianchen92/ARROW-7021 and squashes the following commits: 1268aec <tianchen> add write decimal tests a17dded <tianchen> resolve comments 5b66dcb <tianchen> fix test 8f2df78 <tianchen> ARROW-XXXX: UnionFixedSizeListWriter decimal type should check writer index Authored-by: tianchen <[email protected]> Signed-off-by: Micah Kornfield <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ARROW-7021.
UnionFixedSizeListWriter should check writer index for decimal type (just as other types) to ensure the values written not exceed listSize.
Otherwise, the writer may continue to write data into it’s underlying vector quietly even the the writer.idx() > listSize * index.