ARROW-6709: [JAVA] Jdbc adapter currentIndex should increment when va… #5511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@emkornfield Hmm, unfortunately, I just found a bug, could this change catch up with 0.15? |
Contributor
|
We don't have unit test coverage for this case? |
Contributor
|
Could you add unit tests for nulls as in a follow-up PR |
Contributor
Author
Thanks Micah |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Related to [ARROW-6709](https://issues.apache.org/jira/browse/ARROW-6709). Currently, in several consumers, currentIndex only increments when ResultSet was not null. However, if ResultSet contains null values, the Arrow vector valueCount is not correct. Closes apache#5511 from tianchen92/ARROW-6709 and squashes the following commits: b1e9d5a <tianchen> ARROW-6709: Jdbc adapter currentIndex should increment when value is null Authored-by: tianchen <[email protected]> Signed-off-by: Micah Kornfield <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ARROW-6709.
Currently, in several consumers, currentIndex only increments when ResultSet was not null.
However, if ResultSet contains null values, the Arrow vector valueCount is not correct.