ARROW-6086: [Rust] [DataFusion] Add support for partitioned Parquet data sources #5494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Sorry @paddyhoran I found this last minute issue ... pretty small fix though. |
paddyhoran
approved these changes
Sep 25, 2019
Contributor
paddyhoran
left a comment
paddyhoran
left a comment
There was a problem hiding this comment.
LGTM, just one question.
| Err(ExecutionError::General("No files found".to_string())) | ||
| } else { | ||
| let parquet_file = ParquetFile::open(&filenames[0], None, 0)?; | ||
| let schema = parquet_file.projection_schema.clone(); |
Contributor
There was a problem hiding this comment.
What happens if the schema of the files differ? I guess it just fails are execution time when a different schema is encountered?
Member
Author
There was a problem hiding this comment.
Yes, this code assumes that all of the partitions have the same schema currently. It's pretty basic. I imagine we could eventually have schema merging.
Member
Author
There was a problem hiding this comment.
I will write up a JIRA to add validation that all the partitions have the same schema. That would be a nice improvement.
Contributor
There was a problem hiding this comment.
Makes sense. Feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this last minute while running manual tests. I have been able to run parallel queries against parquet files using this branch as a dependency.