ARROW-6649: [R] print methods for Array, ChunkedArray, Table, RecordBatch #5492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Sep 24, 2019
| ) | ||
| ) | ||
| DictionaryType$create <- function(index_type = int32(), | ||
| value_type = utf8(), |
Member
There was a problem hiding this comment.
Looks weird to have default values for the type parameters.
Member
Author
There was a problem hiding this comment.
Maybe so, but this is what an R factor type gets translated to, so it seemed reasonable.
r/tests/testthat/test-RecordBatch.R
Outdated
| "$dbl <double>", | ||
| "$lgl <bool>", | ||
| "$chr <string>", | ||
| "$fct <dictionary<values=string, indices=int8, ordered=0>>", |
Member
There was a problem hiding this comment.
Just for the record, R doesn't have boolean values? ("ordered=0")
Member
Author
There was a problem hiding this comment.
It does, but this is coming straight from the C++ ToString method. I guess I could munge it in R.
Member
Author
There was a problem hiding this comment.
I added some munging in 02afb89#diff-63df045aa8aff63fdd460b816987ba0dR65-R69
bkietz
approved these changes
Sep 24, 2019
Co-Authored-By: Benjamin Kietzman <[email protected]>
Member
Author
|
Travis passed here: https://travis-ci.org/nealrichardson/arrow/builds/589196708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the readme and the new tests for example output.
This patch also fixes a validation bug in
dictionary(), aliases that toDictionaryType$create, and adds default arguments.