-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-6686: [CI] Pull and push docker images to speed up the nightly builds #5485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ursabot crossbow submit docker-cpp |
|
AMD64 Conda Crossbow Submit (#64889) builder has been succeeded. Revision: 16ec7f9 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-218
|
|
@ursabot crossbow submit docker-cpp |
|
AMD64 Conda Crossbow Submit (#64890) builder has been succeeded. Revision: 16ec7f9 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-219
|
…_caching [skip ci]
dace9d6 to
d7ab350
Compare
|
@ursabot crossbow submit docker-cpp |
|
AMD64 Conda Crossbow Submit (#64891) builder has been succeeded. Revision: d7ab350 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-220
|
|
@ursabot crossbow submit docker-cpp |
|
AMD64 Conda Crossbow Submit (#64892) builder has been succeeded. Revision: 4c7cee0 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-221
|
|
@ursabot crossbow submit docker-cpp |
|
AMD64 Conda Crossbow Submit (#64893) builder has been succeeded. Revision: 9718b00 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-222
|
|
@ursabot crossbow submit docker-cpp |
|
AMD64 Conda Crossbow Submit (#64905) builder has been succeeded. Revision: 60c40f5 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-223
|
|
@ursabot crossbow submit docker-cpp |
|
AMD64 Conda Crossbow Submit (#64918) builder has been succeeded. Revision: a0b7fb1 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-224
|
|
@ursabot crossbow submit -g cpp-python |
|
AMD64 Conda Crossbow Submit (#64944) builder has been succeeded. Revision: a0b7fb1 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-225 |
|
@ursabot crossbow submit -g cpp-python |
|
AMD64 Conda Crossbow Submit (#65003) builder has been succeeded. Revision: 44f0585 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-226 |
|
@ursabot crossbow submit -g cpp-python |
|
AMD64 Conda Crossbow Submit (#65019) builder has been succeeded. Revision: 36bcaa9 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-227 |
Codecov Report
@@ Coverage Diff @@
## master #5485 +/- ##
==========================================
- Coverage 69.97% 66.29% -3.69%
==========================================
Files 755 507 -248
Lines 89329 69997 -19332
Branches 1498 0 -1498
==========================================
- Hits 62509 46402 -16107
+ Misses 26455 23595 -2860
+ Partials 365 0 -365
Continue to review full report at Codecov.
|
|
@ursabot crossbow submit -g cpp-python |
|
AMD64 Conda Crossbow Submit (#65128) builder has been succeeded. Revision: 36bcaa9 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-228 |
|
@ursabot crossbow submit docker-spark-integration |
|
AMD64 Conda Crossbow Submit (#65329) builder has been succeeded. Revision: 36bcaa9 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-231
|
|
@ursabot crossbow submit -g cpp-python |
|
AMD64 Conda Crossbow Submit (#65487) builder has been succeeded. Revision: 2f8564f Submitted crossbow builds: ursa-labs/crossbow @ ursabot-232 |
|
@nealrichardson for docker-cpp it took ~40m before and ~25 after. The build time of docker-python-3.6 has decreased from ~28m to 17m. |
|
@emkornfield FYI in case you want to merge this to make the builds faster |
|
Looking |
wesm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. I think this is OK as a stopgap. It would be good if we can make an Arrow developer org on Docker Hub so that we can provide blanket administration rights to other PMC members.
|
@kszucs @nealrichardson can you ensure that the process to modify these cached images is properly documented? I didn't see anything about that from scanning this. Looks like there is a lint failure so I can't merge this yet |
|
Will fix it |
kszucs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
@kszucs do you want to let the Arrow commiters know about the "arrowdev" Docker Hub organization? We should add any committer that wants access |
…builds The images are available under https://hub.docker.com/u/ursalab with arrow prefix. Also resolves https://issues.apache.org/jira/browse/ARROW-2602 Closes #5485 from kszucs/docker-push-pull and squashes the following commits: 086c7b3 <Krisztián Szűcs> hadolint f1b5956 <Krisztián Szűcs> use arrowdev org 2f8564f <Krisztián Szűcs> push only images built from arrow's master branch 36bcaa9 <Krisztián Szűcs> update dockerfiles 44f0585 <Krisztián Szűcs> ignore pull failures a0b7fb1 <Krisztián Szűcs> disable master only push for now 60c40f5 <Krisztián Szűcs> jinja 9718b00 <Krisztián Szűcs> quote 4c7cee0 <Krisztián Szűcs> try to fix circle yml d7ab350 <Krisztián Szűcs> increase no_output_timeout; use newer machine image with docker_layer_caching c6f71a9 <Krisztián Szűcs> push from master only 16ec7f9 <Krisztián Szűcs> pull and push docker images to dockerhub to speed up the builds Authored-by: Krisztián Szűcs <[email protected]> Signed-off-by: Krisztián Szűcs <[email protected]>
The images are available under https://hub.docker.com/u/ursalab with arrow prefix.
Also resolves https://issues.apache.org/jira/browse/ARROW-2602