Skip to content

Conversation

@kszucs
Copy link
Member

@kszucs kszucs commented Sep 24, 2019

The images are available under https://hub.docker.com/u/ursalab with arrow prefix.

Also resolves https://issues.apache.org/jira/browse/ARROW-2602

@kszucs
Copy link
Member Author

kszucs commented Sep 24, 2019

@ursabot crossbow submit docker-cpp

@ursabot
Copy link

ursabot commented Sep 24, 2019

AMD64 Conda Crossbow Submit (#64889) builder has been succeeded.

Revision: 16ec7f9

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-218

Task Status
docker-cpp CircleCI

@kszucs
Copy link
Member Author

kszucs commented Sep 24, 2019

@ursabot crossbow submit docker-cpp

@ursabot
Copy link

ursabot commented Sep 24, 2019

AMD64 Conda Crossbow Submit (#64890) builder has been succeeded.

Revision: 16ec7f9

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-219

Task Status
docker-cpp CircleCI

@kszucs
Copy link
Member Author

kszucs commented Sep 24, 2019

@ursabot crossbow submit docker-cpp

@ursabot
Copy link

ursabot commented Sep 24, 2019

AMD64 Conda Crossbow Submit (#64891) builder has been succeeded.

Revision: d7ab350

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-220

Task Status
docker-cpp CircleCI

@kszucs
Copy link
Member Author

kszucs commented Sep 24, 2019

@ursabot crossbow submit docker-cpp

@ursabot
Copy link

ursabot commented Sep 24, 2019

AMD64 Conda Crossbow Submit (#64892) builder has been succeeded.

Revision: 4c7cee0

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-221

Task Status
docker-cpp CircleCI

@kszucs
Copy link
Member Author

kszucs commented Sep 24, 2019

@ursabot crossbow submit docker-cpp

@ursabot
Copy link

ursabot commented Sep 24, 2019

AMD64 Conda Crossbow Submit (#64893) builder has been succeeded.

Revision: 9718b00

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-222

Task Status
docker-cpp CircleCI

@kszucs
Copy link
Member Author

kszucs commented Sep 24, 2019

@ursabot crossbow submit docker-cpp

@ursabot
Copy link

ursabot commented Sep 24, 2019

AMD64 Conda Crossbow Submit (#64905) builder has been succeeded.

Revision: 60c40f5

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-223

Task Status
docker-cpp CircleCI

@kszucs
Copy link
Member Author

kszucs commented Sep 24, 2019

@ursabot crossbow submit docker-cpp

@ursabot
Copy link

ursabot commented Sep 24, 2019

AMD64 Conda Crossbow Submit (#64918) builder has been succeeded.

Revision: a0b7fb1

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-224

Task Status
docker-cpp CircleCI

@kszucs
Copy link
Member Author

kszucs commented Sep 24, 2019

@ursabot crossbow submit -g cpp-python

@ursabot
Copy link

ursabot commented Sep 24, 2019

AMD64 Conda Crossbow Submit (#64944) builder has been succeeded.

Revision: a0b7fb1

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-225

Task Status
docker-cpp CircleCI
docker-cpp-alpine CircleCI
docker-cpp-cmake32 CircleCI
docker-python-2.7 CircleCI
docker-python-2.7-alpine CircleCI
docker-python-2.7-nopandas CircleCI
docker-python-3.6 CircleCI
docker-python-3.6-alpine CircleCI
docker-python-3.6-nopandas CircleCI
docker-python-3.7 CircleCI

@kszucs
Copy link
Member Author

kszucs commented Sep 24, 2019

@ursabot crossbow submit -g cpp-python

@ursabot
Copy link

ursabot commented Sep 24, 2019

AMD64 Conda Crossbow Submit (#65003) builder has been succeeded.

Revision: 44f0585

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-226

Task Status
docker-cpp CircleCI
docker-cpp-alpine CircleCI
docker-cpp-cmake32 CircleCI
docker-python-2.7 CircleCI
docker-python-2.7-alpine CircleCI
docker-python-2.7-nopandas CircleCI
docker-python-3.6 CircleCI
docker-python-3.6-alpine CircleCI
docker-python-3.6-nopandas CircleCI
docker-python-3.7 CircleCI

@kszucs
Copy link
Member Author

kszucs commented Sep 24, 2019

@ursabot crossbow submit -g cpp-python

@ursabot
Copy link

ursabot commented Sep 24, 2019

AMD64 Conda Crossbow Submit (#65019) builder has been succeeded.

Revision: 36bcaa9

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-227

Task Status
docker-cpp CircleCI
docker-cpp-alpine CircleCI
docker-cpp-cmake32 CircleCI
docker-python-2.7 CircleCI
docker-python-2.7-alpine CircleCI
docker-python-2.7-nopandas CircleCI
docker-python-3.6 CircleCI
docker-python-3.6-alpine CircleCI
docker-python-3.6-nopandas CircleCI
docker-python-3.7 CircleCI

@codecov-io
Copy link

Codecov Report

Merging #5485 into master will decrease coverage by 3.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5485      +/-   ##
==========================================
- Coverage   69.97%   66.29%   -3.69%     
==========================================
  Files         755      507     -248     
  Lines       89329    69997   -19332     
  Branches     1498        0    -1498     
==========================================
- Hits        62509    46402   -16107     
+ Misses      26455    23595    -2860     
+ Partials      365        0     -365
Impacted Files Coverage Δ
cpp/src/arrow/filesystem/filesystem.cc 49.7% <0%> (-21.13%) ⬇️
cpp/src/arrow/filesystem/filesystem.h 91.66% <0%> (-8.34%) ⬇️
python/pyarrow/array.pxi 79.11% <0%> (-0.13%) ⬇️
r/src/recordbatch.cpp
go/arrow/math/uint64_amd64.go
r/R/filesystem.R
r/R/list.R
r/src/symbols.cpp
r/src/array_to_vector.cpp
go/arrow/ipc/file_reader.go
... and 252 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b6d07...36bcaa9. Read the comment docs.

@kszucs
Copy link
Member Author

kszucs commented Sep 24, 2019

@ursabot crossbow submit -g cpp-python

@ursabot
Copy link

ursabot commented Sep 24, 2019

AMD64 Conda Crossbow Submit (#65128) builder has been succeeded.

Revision: 36bcaa9

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-228

Task Status
docker-cpp CircleCI
docker-cpp-alpine CircleCI
docker-cpp-cmake32 CircleCI
docker-python-2.7 CircleCI
docker-python-2.7-alpine CircleCI
docker-python-2.7-nopandas CircleCI
docker-python-3.6 CircleCI
docker-python-3.6-alpine CircleCI
docker-python-3.6-nopandas CircleCI
docker-python-3.7 CircleCI

@kszucs
Copy link
Member Author

kszucs commented Sep 25, 2019

@ursabot crossbow submit docker-spark-integration

@ursabot
Copy link

ursabot commented Sep 25, 2019

AMD64 Conda Crossbow Submit (#65329) builder has been succeeded.

Revision: 36bcaa9

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-231

Task Status
docker-spark-integration CircleCI

@kszucs kszucs changed the title [Testing] Pull and push docker images to speed up the nightly builds ARROW-6686: [CI] Pull and push docker images to speed up the nightly builds Sep 25, 2019
@kszucs kszucs requested a review from xhochy September 25, 2019 13:00
@kszucs
Copy link
Member Author

kszucs commented Sep 25, 2019

@ursabot crossbow submit -g cpp-python

@ursabot
Copy link

ursabot commented Sep 25, 2019

AMD64 Conda Crossbow Submit (#65487) builder has been succeeded.

Revision: 2f8564f

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-232

Task Status
docker-cpp CircleCI
docker-cpp-alpine CircleCI
docker-cpp-cmake32 CircleCI
docker-python-2.7 CircleCI
docker-python-2.7-alpine CircleCI
docker-python-2.7-nopandas CircleCI
docker-python-3.6 CircleCI
docker-python-3.6-alpine CircleCI
docker-python-3.6-nopandas CircleCI
docker-python-3.7 CircleCI

@kszucs
Copy link
Member Author

kszucs commented Sep 26, 2019

@nealrichardson for docker-cpp it took ~40m before and ~25 after. The build time of docker-python-3.6 has decreased from ~28m to 17m.

@pitrou
Copy link
Member

pitrou commented Sep 26, 2019

@wesm

@nealrichardson
Copy link
Member

@emkornfield FYI in case you want to merge this to make the builds faster

@wesm
Copy link
Member

wesm commented Sep 27, 2019

Looking

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I think this is OK as a stopgap. It would be good if we can make an Arrow developer org on Docker Hub so that we can provide blanket administration rights to other PMC members.

@wesm
Copy link
Member

wesm commented Sep 27, 2019

@kszucs @nealrichardson can you ensure that the process to modify these cached images is properly documented? I didn't see anything about that from scanning this.

Looks like there is a lint failure so I can't merge this yet

+pre-commit install
pre-commit installed at .git/hooks/pre-commit
+pre-commit run hadolint -a
[WARNING] Unexpected key(s) present on git://github.com/pre-commit/pre-commit-hooks: sha
[INFO] Initializing environment for local.
[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
Docker Format............................................................Failed
hookid: hadolint

@kszucs
Copy link
Member Author

kszucs commented Sep 27, 2019

Will fix it

@github-actions
Copy link

Copy link
Member Author

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kszucs kszucs closed this in 1165cdb Oct 3, 2019
@wesm
Copy link
Member

wesm commented Oct 3, 2019

@kszucs do you want to let the Arrow commiters know about the "arrowdev" Docker Hub organization? We should add any committer that wants access

kszucs added a commit that referenced this pull request Oct 5, 2019
…builds

The images are available under https://hub.docker.com/u/ursalab with arrow prefix.

Also resolves https://issues.apache.org/jira/browse/ARROW-2602

Closes #5485 from kszucs/docker-push-pull and squashes the following commits:

086c7b3 <Krisztián Szűcs> hadolint
f1b5956 <Krisztián Szűcs> use arrowdev org
2f8564f <Krisztián Szűcs> push only images built from arrow's master branch
36bcaa9 <Krisztián Szűcs> update dockerfiles
44f0585 <Krisztián Szűcs> ignore pull failures
a0b7fb1 <Krisztián Szűcs> disable master only push for now
60c40f5 <Krisztián Szűcs> jinja
9718b00 <Krisztián Szűcs> quote
4c7cee0 <Krisztián Szűcs> try to fix circle yml
d7ab350 <Krisztián Szűcs> increase no_output_timeout; use newer machine image with docker_layer_caching
c6f71a9 <Krisztián Szűcs> push from master only
16ec7f9 <Krisztián Szűcs> pull and push docker images to dockerhub to speed up the builds

Authored-by: Krisztián Szűcs <[email protected]>
Signed-off-by: Krisztián Szűcs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants