ARROW-6669: [Rust] [DataFusion] Implement binary expression for physical plan #5478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
force-pushed
the
ARROW-6669
branch
from
4177823 to
7a1a49e
Compare
paddyhoran
requested changes
Sep 24, 2019
Contributor
paddyhoran
left a comment
paddyhoran
left a comment
There was a problem hiding this comment.
Overall LGTM, just one question.
Contributor
There was a problem hiding this comment.
I think you need to check that left.data_type() is boolean before using the boolean_op macro. If you pass an array with another data type though here it will downcast to a boolean array but, of course, would be incorrect.
Member
Author
There was a problem hiding this comment.
Good catch, thanks. I think the current code would have failed on the downcast resulting in a panic if the types were wrong (not great), and explicit checks make sense. I pushed this change and also rebased.
andygrove
force-pushed
the
ARROW-6669
branch
from
7a1a49e to
bb82a24
Compare
paddyhoran
approved these changes
Sep 24, 2019
| ))); | ||
| } | ||
| } | ||
| Operator::Or => { |
Contributor
There was a problem hiding this comment.
It's a shame this has to be repeated instead of using Operator::And | Operator::Or
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the binary expression to the new physical execution plan, with support for comparison operators (
<,<=,>,>=,==,!=) and boolean operatorsANDandOR.Other binary expressions, such as math expressions will be added in a future PR.