ARROW-6668: [Rust] [DataFusion] Implement CAST expression #5477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
andygrove
force-pushed
the
ARROW-6668
branch
from
216ef0f to
f025008
Compare
paddyhoran
approved these changes
Sep 23, 2019
Contributor
paddyhoran
left a comment
paddyhoran
left a comment
There was a problem hiding this comment.
LGTM, thanks @andygrove
| let result = result | ||
| .as_any() | ||
| .downcast_ref::<UInt32Array>() | ||
| .expect("failed to downcast to UInt32Array"); |
Contributor
There was a problem hiding this comment.
I'm curious about how the API is designed to work here. Why don't you handle the downcast in evaluate based on data_type()? Is it just that you don't want the user to always incur the cost of the match on data_type().
|
|
||
| impl PhysicalExpr for CastExpr { | ||
| fn name(&self) -> String { | ||
| "CAST".to_string() |
Contributor
There was a problem hiding this comment.
nit: there is inconsistency in upper vs lower case for name. The literal one was lower case, this one and SUM were upper case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.