-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-6429: [Integration] Adding patch to fix Spark compilation for Integrition tests #5465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
BryanCutler
wants to merge
4
commits into
apache:master
from
BryanCutler:spark-integration-patch-ARROW-6429
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala | ||
| index 1a6f4ac..42d555b 100644 | ||
| --- a/sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala | ||
| +++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala | ||
| @@ -26,7 +26,7 @@ import org.apache.arrow.flatbuf.MessageHeader | ||
| import org.apache.arrow.memory.BufferAllocator | ||
| import org.apache.arrow.vector._ | ||
| import org.apache.arrow.vector.ipc.{ArrowStreamWriter, ReadChannel, WriteChannel} | ||
| -import org.apache.arrow.vector.ipc.message.{ArrowRecordBatch, MessageSerializer} | ||
| +import org.apache.arrow.vector.ipc.message.{ArrowRecordBatch, IpcOption, MessageSerializer} | ||
|
|
||
| import org.apache.spark.TaskContext | ||
| import org.apache.spark.api.java.JavaRDD | ||
| @@ -64,7 +64,7 @@ private[sql] class ArrowBatchStreamWriter( | ||
| * End the Arrow stream, does not close output stream. | ||
| */ | ||
| def end(): Unit = { | ||
| - ArrowStreamWriter.writeEndOfStream(writeChannel) | ||
| + ArrowStreamWriter.writeEndOfStream(writeChannel, new IpcOption) | ||
| } | ||
| } | ||
|
|
||
| @@ -252,7 +252,7 @@ private[sql] object ArrowConverters { | ||
| if (msgMetadata.getMessage.headerType() == MessageHeader.RecordBatch) { | ||
|
|
||
| // Buffer backed output large enough to hold the complete serialized message | ||
| - val bbout = new ByteBufferOutputStream(4 + msgMetadata.getMessageLength + bodyLength) | ||
| + val bbout = new ByteBufferOutputStream(8 + msgMetadata.getMessageLength + bodyLength) | ||
|
|
||
| // Write message metadata to ByteBuffer output stream | ||
| MessageSerializer.writeMessageBuffer( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,8 +47,6 @@ pushd /spark | |
| build/mvn -B -Dtest=none -DwildcardSuites=$(IFS=,; echo "${SPARK_SCALA_TESTS[*]}") test | ||
|
|
||
| # Run pyarrow related Python tests only | ||
| echo "Testing PySpark:" | ||
|
|
||
| SPARK_PYTHON_TESTS=( | ||
| "pyspark.sql.tests.test_arrow" | ||
| "pyspark.sql.tests.test_pandas_udf" | ||
|
|
@@ -58,5 +56,5 @@ pushd /spark | |
| "pyspark.sql.tests.test_pandas_udf_window") | ||
|
|
||
| (echo "Testing PySpark:"; IFS=$'\n'; echo "${SPARK_PYTHON_TESTS[*]}") | ||
| python/run-tests --testnames "$(IFS=,; echo "${SPARK_PYTHON_TESTS[*]}")" | ||
| python/run-tests --testnames "$(IFS=,; echo "${SPARK_PYTHON_TESTS[*]}")" --python-executables python | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Spark will look for and test separately against installed python versions, so setting this will make sure to run the tests once on the default python |
||
| popd | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the minimum version used by Spark, so setting this here will prevent Spark from downloading it during the build phase