ARROW-6556: [Python] Fix warning for pandas SparseDataFrame removal #5438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ursabot crossbow submit docker-pandas-master |
|
AMD64 Conda Crossbow Submit (#63595) builder has been succeeded. Revision: 06a0738 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-205
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on https://issues.apache.org/jira/browse/ARROW-6556 / #5377.
We were a bit fast with merging the other PR, as pandas changed the removal slightly (it added back a dummy SparseDataFrame object which triggers a warning upon access, but this means that
hasattr(pd, 'SparseDataFrame)or try/except on import is not a good check to know if the actual class still exists or not).Using pytests warnings filter I now ensure no such warning is raised in our test suite.