Skip to content

ARROW-6131: [C++] Optimize the Arrow Non-Ascii-string-validation #5038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guyuqi wants to merge 4 commits into from
Closed

ARROW-6131: [C++] Optimize the Arrow Non-Ascii-string-validation #5038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
264bb7e
ARROW-6131: [C++] Optimize the Arrow Non-Ascii-string-validation
guyuqi Jul 30, 2019
a6ffdec
Add ValidateNonAscii to utility-test and rebase to master
guyuqi Aug 27, 2019
34ed1e7
Opimize Ascii-validation
guyuqi Oct 11, 2019
f5dcd2b
Fix build issues
guyuqi Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/cmake_modules/SetupCxxFlags.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ endif(BUILD_WARNING_FLAGS)

# Only enable additional instruction sets if they are supported
if(CXX_SUPPORTS_SSE4_2 AND ARROW_SSE42)
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -msse4.2")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -msse4.2 -Wno-narrowing")
endif()

if(CXX_SUPPORTS_ALTIVEC AND ARROW_ALTIVEC)
Expand Down
6 changes: 5 additions & 1 deletion cpp/src/arrow/util/neon_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,16 @@ namespace arrow {

#define ARROW_HAVE_NEON 1

#if defined(__ARM_NEON__) || defined(__ARM_NEON)
#define ARROW_HAVE_ARM_NEON
#include <arm_neon.h>
#endif

#ifdef __ARM_FEATURE_CRC32
#define ARROW_HAVE_ARM_CRC
#include <arm_acle.h>

#ifdef __ARM_FEATURE_CRYPTO
#include <arm_neon.h>
#define ARROW_HAVE_ARMV8_CRYPTO
#endif // __ARM_FEATURE_CRYPTO

Expand Down
Loading