ARROW-5848: [C++] SO versioning schema after release 1.0.0 #4801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kszucs
changed the title
xhochy
approved these changes
Jul 4, 2019
Member
xhochy
left a comment
xhochy
left a comment
There was a problem hiding this comment.
+1, quite happy with this. I don't expect us to have a longterm stable ABI yet. Once we have reached this, we should slow down on SO version bumps.
pitrou
reviewed
Jul 4, 2019
Member
|
@kszucs Need to re-run cmake-format, see https://travis-ci.org/kszucs/arrow/jobs/554237034 |
Member
Author
|
Ahh, thanks for notifying me. |
Member
|
Can you cancel the old builds on your Travis and AppVeyor account? |
Member
Author
|
Done. |
Member
|
I merged to unstuck other PRs. Thank you! |
kszucs
added a commit
that referenced
this pull request
Jul 22, 2019
Described by @kou on the mailing list: > If we may break ABI compatibility each minor version up > release ("Y" is increased in "X.Y.Z"), we should include > minor version into SO major version (100, 101 and 102 in the > following examples): > > * 1.0.0 -> libarrow.100.0.0 > * 1.1.0 -> libarrow.101.0.0 > * 1.2.0 -> libarrow.102.0.0 > > If we don't break ABI compatibility each minor version up > release, we just use the same SO major version (100 in the > following examples) in 1.0.0: > > * 1.0.0 -> libarrow.100.0.0 > * 1.1.0 -> libarrow.100.1.0 > * 1.2.0 -> libarrow.100.2.0 > > I choose 1XX as SO major version because we already use > 10-14 for SO major version. We should not use them in the > future to avoid confusion. So I choose 1XX in the above > examples. We can change this schema later, but to resolve the CI failures we need a solution for now. Author: Krisztián Szűcs <[email protected]> Closes #4801 from kszucs/so-versioning and squashes the following commits: 81519fe <Krisztián Szűcs> cmake-format 74a8cbf <Krisztián Szűcs> fix full so-version in comment 431ef56 <Krisztián Szűcs> update SO versioning
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Described by @kou on the mailing list:
We can change this schema later, but to resolve the CI failures we need a solution for now.