GH-47946: [C++][Parquet] Fix Simd inclusion paths #47952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
3 tasks
github-actions
bot
added
awaiting changes
pitrou
reviewed
Oct 27, 2025
Member
|
@github-actions crossbow submit -g cpp |
|
Revision: 14b0387 Submitted crossbow builds: ursacomputing/crossbow @ actions-2b86389ef5
|
Co-authored-by: Antoine Pitrou <[email protected]>
github-actions
bot
added
awaiting change review
Member
|
Sorry, there is a lint failure that needs fixing after my suggestion :( |
raulcd
approved these changes
Oct 27, 2025
Member
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
Thanks for the quick fix @AntoinePrv
github-actions
bot
added
awaiting merge
Member
|
CI failures are unrelated. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 00245cc. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Nov 5, 2025
### Rationale for this change Fix build with `ARROW_SIMD_LEVEL=NONE` and `ARROW_RUNTIME_SIMD_LEVEL` set to something else than `NONE`. ### Are these changes tested? Locally. Adding a CI test case with `ARROW_SIMD_LEVEL=NONE` may prove useful in preventing further regressions. ### Are there any user-facing changes? No * GitHub Issue: apache#47946 Lead-authored-by: AntoinePrv <[email protected]> Co-authored-by: Antoine Prouvost <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix build with
ARROW_SIMD_LEVEL=NONEandARROW_RUNTIME_SIMD_LEVELset to something else thanNONE.Are these changes tested?
Locally. Adding a CI test case with
ARROW_SIMD_LEVEL=NONEmay prove useful in preventing further regressions.Are there any user-facing changes?
No