GH-47807: [C++][Compute] Fix the issue that null count is not updated when setting slice on an array span #47808
+59
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@github-actions crossbow submit -g cpp -g python |
|
Revision: 2bc7a2a Submitted crossbow builds: ursacomputing/crossbow @ actions-46fae40cf9
|
pitrou
approved these changes
Oct 14, 2025
| auto indices = ArrayFromJSON(int64(), "[0, 1, 0, 1, 0, null]"); | ||
| auto values1 = ArrayFromJSON(int64(), "[10, 11, 12, 13, 14, 15]"); | ||
| auto values2 = ChunkedArrayFromJSON(int64(), {"[100, 101]", "[102, 103, 104, 105]"}); | ||
| ASSERT_OK_AND_ASSIGN(auto result, CallFunction("choose", {indices, values1, values2})); |
There was a problem hiding this comment.
Also call result.chunked_array()->ValidateFull()?
There was a problem hiding this comment.
Right, done.
Thanks!
github-actions
bot
added
awaiting committer review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The null count is not updated when setting slice on an array span, after a preceding set slice sees a 0 null count. An incorrectly null count will cause subsequent failures wrt. null processing like #47807.
What changes are included in this PR?
Narrowing the null count update condition when setting slice on an array span: as long as there is a valid buffer, we set null count to unknown.
Are these changes tested?
Test included.
Are there any user-facing changes?
None.
choosefunction on chunked input #47807